refactor: nit change for get_parameters_from_modules (code debt)#3815
Merged
SunMarc merged 2 commits intohuggingface:mainfrom Oct 14, 2025
Merged
refactor: nit change for get_parameters_from_modules (code debt)#3815SunMarc merged 2 commits intohuggingface:mainfrom
SunMarc merged 2 commits intohuggingface:mainfrom
Conversation
Signed-off-by: Mehant Kammakomati <mehant.kammakomati2@ibm.com>
kmehant
changed the title
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Signed-off-by: Mehant Kammakomati <mehant.kammakomati2@ibm.com>
This was referenced Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is a simple refactor patch over my previous PR contributing ignored_params for FSPDv2 #3731. Apologies for type inconsistency in my previous PR that can bring brought us some unnecessary code debt which we could easily avoid with this simple PR.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@SunMarc @S1ro1